netdev - Re: [PATCH net] can: isotp: add result check for wait_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fcfeb88-d49d-2a2a-1524-8504eb848123@huawei.com>
Date:   Mon, 27 Sep 2021 09:39:54 +0800
From:   "Ziyang Xuan (William)" <william.xuanziyang@...wei.com>
To:     <socketcan@...tkopp.net>
CC:     <mkl@...gutronix.de>, <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-can@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net] can: isotp: add result check for
 wait_event_interruptible()

> Using wait_event_interruptible() to wait for complete transmission,
> but do not check the result of wait_event_interruptible() which can
> be interrupted. It will result in tx buffer has multiple accessers
> and the later process interferes with the previous process.
> 
> Following is one of the problems reported by syzbot.
> 
> =============================================================
> WARNING: CPU: 0 PID: 0 at net/can/isotp.c:840 isotp_tx_timer_handler+0x2e0/0x4c0
> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.13.0-rc7+ #68
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1 04/01/2014
> RIP: 0010:isotp_tx_timer_handler+0x2e0/0x4c0
> Call Trace:
>  <IRQ>
>  ? isotp_setsockopt+0x390/0x390
>  __hrtimer_run_queues+0xb8/0x610
>  hrtimer_run_softirq+0x91/0xd0
>  ? rcu_read_lock_sched_held+0x4d/0x80
>  __do_softirq+0xe8/0x553
>  irq_exit_rcu+0xf8/0x100
>  sysvec_apic_timer_interrupt+0x9e/0xc0
>  </IRQ>
>  asm_sysvec_apic_timer_interrupt+0x12/0x20
> 
> Add result check for wait_event_interruptible() in isotp_sendmsg()
> to avoid multiple accessers for tx buffer.
> 
> Reported-by: syzbot+78bab6958a614b0c80b9@...kaller.appspotmail.com
> Fixes: e057dd3fc20f ("can: add ISO 15765-2:2016 transport protocol")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@...wei.com>

Hi Oliver,
I send a new patch with this problem, ignore this patch please.

Thank you!