netdev - Re: [PATCH bpf-next v2 2/3] libbpf: support detecting and attaching of writable tracepoint program

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <140f8e1e-cdc7-efd5-1411-f1cd2ffe304d@huawei.com>
Date:   Tue, 28 Sep 2021 20:28:35 +0800
From:   Hou Tao <houtao1@...wei.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
CC:     Alexei Starovoitov <ast@...nel.org>, Yonghong Song <yhs@...com>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        "Martin KaFai Lau" <kafai@...com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v2 2/3] libbpf: support detecting and attaching
 of writable tracepoint program

Hi,

On 9/22/2021 5:42 AM, Andrii Nakryiko wrote:
> On Fri, Sep 17, 2021 at 6:56 PM Hou Tao <houtao1@...wei.com> wrote:
>> Program on writable tracepoint is BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE,
>> but its attachment is the same as BPF_PROG_TYPE_RAW_TRACEPOINT.
>>
>> Signed-off-by: Hou Tao <houtao1@...wei.com>
>> ---
>>  tools/lib/bpf/libbpf.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
>> index da65a1666a5e..981fcdd95bdc 100644
>> --- a/tools/lib/bpf/libbpf.c
>> +++ b/tools/lib/bpf/libbpf.c
>> @@ -7976,6 +7976,10 @@ static const struct bpf_sec_def section_defs[] = {
>>                 .attach_fn = attach_raw_tp),
>>         SEC_DEF("raw_tp/", RAW_TRACEPOINT,
>>                 .attach_fn = attach_raw_tp),
>> +       SEC_DEF("raw_tracepoint_writable/", RAW_TRACEPOINT_WRITABLE,
>> +               .attach_fn = attach_raw_tp),
>> +       SEC_DEF("raw_tp_writable/", RAW_TRACEPOINT_WRITABLE,
>> +               .attach_fn = attach_raw_tp),
> _writable is a bit mouthful, maybe we should do the same we did for
> "sleepable", just add ".w" suffix? So it will be "raw_tp.w/..."? Or
> does anyone feel it's too subtle?
raw_tp.w is fine to me. Will update it in v3.
>
>>         SEC_DEF("tp_btf/", TRACING,
>>                 .expected_attach_type = BPF_TRACE_RAW_TP,
>>                 .is_attach_btf = true,
>> --
>> 2.29.2
>>
> .