netdev - Re: [PATCH v2] iplink_rmnet: Allow passing IFLA_RMNET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Sep 2021 20:09:51 -0600
From:   David Ahern <dsahern@...il.com>
To:     Alex Elder <elder@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Daniele Palmas <dnlplm@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2] iplink_rmnet: Allow passing IFLA_RMNET_FLAGS

On 9/27/21 4:44 PM, Alex Elder wrote:
> On 9/27/21 8:48 AM, David Ahern wrote:
>>>           } else if (matches(*argv, "help") == 0) {
>>>               explain();
>>>               return -1;
>> use strcmp for new options. Also, please use 'csum' instead of 'chksum'
>> in the names. csum is already widely used in ip commands.
> 
> On the csum remark, I agree completely.
> 
> On the other:  Are you saying to use strcmp() instead of
> matches()?
> 
> That seems strange to me because matches() is used *much*
> more often than strcmp(), and handles an empty *argv
> differently.

matches is way beyond its usefulness. Its use is now deprecated. It just
leads to confusing command lines and problems maintaining which option
hits the matches.

> 
> I don't disagree with your suggested change, but upon
> looking at the other code it surprises me a bit.  Can
> you provide a little more explanation?  If you mean
> something else, please clarify.  Thanks.
> 
>                     -Alex