netdev - Re: [PATCH V2 net-next 3/6] ethtool: add support to set/get rx buf len via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f9fcdff-8cf9-8a56-196b-afd0aee7d0c7@huawei.com>
Date:   Wed, 29 Sep 2021 10:21:11 +0800
From:   "huangguangbin (A)" <huangguangbin2@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <mkubecek@...e.cz>, <andrew@...n.ch>,
        <amitc@...lanox.com>, <idosch@...sch.org>, <danieller@...dia.com>,
        <jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>,
        <jdike@...toit.com>, <richard@....at>,
        <anton.ivanov@...bridgegreys.com>, <netanel@...zon.com>,
        <akiyano@...zon.com>, <gtzalik@...zon.com>, <saeedb@...zon.com>,
        <chris.snook@...il.com>, <ulli.kroll@...glemail.com>,
        <linus.walleij@...aro.org>, <jeroendb@...gle.com>,
        <csully@...gle.com>, <awogbemila@...gle.com>, <jdmason@...zu.us>,
        <rain.1986.08.12@...il.com>, <zyjzyj2000@...il.com>,
        <kys@...rosoft.com>, <haiyangz@...rosoft.com>, <mst@...hat.com>,
        <jasowang@...hat.com>, <doshir@...are.com>,
        <pv-drivers@...are.com>, <jwi@...ux.ibm.com>,
        <kgraul@...ux.ibm.com>, <hca@...ux.ibm.com>, <gor@...ux.ibm.com>,
        <johannes@...solutions.net>, <netdev@...r.kernel.org>,
        <lipeng321@...wei.com>, <chenhao288@...ilicon.com>,
        <linux-s390@...r.kernel.org>
Subject: Re: [PATCH V2 net-next 3/6] ethtool: add support to set/get rx buf
 len via ethtool



On 2021/9/25 1:47, Jakub Kicinski wrote:
> On Fri, 24 Sep 2021 22:29:56 +0800 Guangbin Huang wrote:
>> @@ -621,9 +631,13 @@ struct ethtool_ops {
>>   				struct kernel_ethtool_coalesce *,
>>   				struct netlink_ext_ack *);
>>   	void	(*get_ringparam)(struct net_device *,
>> -				 struct ethtool_ringparam *);
>> +				 struct ethtool_ringparam *,
>> +				 struct ethtool_ringparam_ext *,
>> +				 struct netlink_ext_ack *);
>>   	int	(*set_ringparam)(struct net_device *,
>> -				 struct ethtool_ringparam *);
>> +				 struct ethtool_ringparam *,
>> +				 struct ethtool_ringparam_ext *,
>> +				 struct netlink_ext_ack *);
> 
> You need to make the driver changes together with this chunk.
> Otherwise the build will be broken between the two during bisection.
> .
> 
Ok, thanks.