netdev - Re: [PATCH] net: mdio-ipq4019: Fix the error for an optional regs resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Sep 2021 11:11:02 +0800
From:   Cai Huoqing <caihuoqing@...du.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <horatiu.vultur@...rochip.com>, <hkallweit1@...il.com>,
        <linux@...linux.org.uk>, <davem@...emloft.net>, <kuba@...nel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: mdio-ipq4019: Fix the error for an optional regs
 resource

On 28 9月 21 15:31:39, Andrew Lunn wrote:
> On Tue, Sep 28, 2021 at 09:21:57PM +0800, Cai Huoqing wrote:
> > The second resource is optional which is only provided on the chipset
> > IPQ5018. But the blamed commit ignores that and if the resource is
> > not there it just fails.
> > 
> > the resource is used like this,
> > 	if (priv->eth_ldo_rdy) {
> > 		val = readl(priv->eth_ldo_rdy);
> > 		val |= BIT(0);
> > 		writel(val, priv->eth_ldo_rdy);
> > 		fsleep(IPQ_PHY_SET_DELAY_US);
> > 	}
> > 
> > This patch reverts that to still allow the second resource to be optional
> > because other SoC have the some MDIO controller and doesn't need to
> > second resource.
> > 
> > Fix Commit fa14d03e014a ("net: mdio-ipq4019: Make use of
> > devm_platform_ioremap_resource()")
> 
> This is not a valid Fixes: tag.
> 
> Add to your ~/.gitconfig and add:
> 
> [pretty]
>         fixes = Fixes: %h (\"%s\")
> 
> You can then do
> 
> git log --pretty=fixes fa14d03e014a
>
Cool, it is a great help to me:)

Thanks,
Cai
> and get:
> 
> Fixes: fa14d03e014a ("net: mdio-ipq4019: Make use of devm_platform_ioremap_resource()")
> 
> Which is the correct format. Don't wrap it, if it is long.
> 
>       Andrew