netdev - Re: [PATCH] atm: [nicstar] make drain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202109300612.ny2H1qKQ-lkp@intel.com>
Date:   Thu, 30 Sep 2021 06:05:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jordy Zomer <jordy@...ing.systems>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jordy Zomer <jordy@...ing.systems>,
        Chas Williams <3chas3@...il.com>,
        linux-atm-general@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: [nicstar] make drain_scq explicitly unsigned

Hi Jordy,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on horms-ipvs/master net-next/master linus/master v5.15-rc3 next-20210922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jordy-Zomer/atm-nicstar-make-drain_scq-explicitly-unsigned/20210929-153719
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git f936bb42aeb94a069bec7c9e04100d199c372956
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/19ac2516740923c5cba92b42baa45c09c69e260f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jordy-Zomer/atm-nicstar-make-drain_scq-explicitly-unsigned/20210929-153719
        git checkout 19ac2516740923c5cba92b42baa45c09c69e260f
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/atm/nicstar.c:1920:13: error: conflicting types for 'drain_scq'
    1920 | static void drain_scq(ns_dev *card, scq_info *scq, unsigned int pos)
         |             ^~~~~~~~~
   drivers/atm/nicstar.c:137:13: note: previous declaration of 'drain_scq' was here
     137 | static void drain_scq(ns_dev * card, scq_info * scq, int pos);
         |             ^~~~~~~~~
   drivers/atm/nicstar.c:137:13: error: 'drain_scq' used but never defined [-Werror]
>> drivers/atm/nicstar.c:1920:13: error: 'drain_scq' defined but not used [-Werror=unused-function]
    1920 | static void drain_scq(ns_dev *card, scq_info *scq, unsigned int pos)
         |             ^~~~~~~~~
   cc1: all warnings being treated as errors


vim +/drain_scq +1920 drivers/atm/nicstar.c

  1919	
> 1920	static void drain_scq(ns_dev *card, scq_info *scq, unsigned int pos)
  1921	{
  1922		struct atm_vcc *vcc;
  1923		struct sk_buff *skb;
  1924		unsigned int i;
  1925		unsigned long flags;
  1926	
  1927		XPRINTK("nicstar%d: drain_scq() called, scq at 0x%p, pos %u.\n",
  1928			card->index, scq, pos);
  1929		if (pos >= scq->num_entries) {
  1930			printk("nicstar%d: Bad index on drain_scq().\n", card->index);
  1931			return;
  1932		}
  1933	
  1934		spin_lock_irqsave(&scq->lock, flags);
  1935		i = (unsigned int)(scq->tail - scq->base);
  1936		if (++i == scq->num_entries)
  1937			i = 0;
  1938		while (i != pos) {
  1939			skb = scq->skb[i];
  1940			XPRINTK("nicstar%d: freeing skb at 0x%p (index %u).\n",
  1941				card->index, skb, i);
  1942			if (skb != NULL) {
  1943				dma_unmap_single(&card->pcidev->dev,
  1944						 NS_PRV_DMA(skb),
  1945						 skb->len,
  1946						 DMA_TO_DEVICE);
  1947				vcc = ATM_SKB(skb)->vcc;
  1948				if (vcc && vcc->pop != NULL) {
  1949					vcc->pop(vcc, skb);
  1950				} else {
  1951					dev_kfree_skb_irq(skb);
  1952				}
  1953				scq->skb[i] = NULL;
  1954			}
  1955			if (++i == scq->num_entries)
  1956				i = 0;
  1957		}
  1958		scq->tail = scq->base + pos;
  1959		spin_unlock_irqrestore(&scq->lock, flags);
  1960	}
  1961	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (66023 bytes)