netdev - RE: [PATCH] r8152: stop submitting rx for -EPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbd1591fc03f480c9f08cc55585e2e35@realtek.com>
Date:   Wed, 29 Sep 2021 08:14:12 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Jason-ch Chen <jason-ch.chen@...iatek.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "Project_Global_Chrome_Upstream_Group@...iatek.com" 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "hsinyi@...gle.com" <hsinyi@...gle.com>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO

Jason-ch Chen <jason-ch.chen@...iatek.com>
> Sent: Wednesday, September 29, 2021 1:18 PM
[...]
> When unplugging RTL8152 Fast Ethernet Adapter which is plugged
> into an USB HUB, the driver would get -EPROTO for bulk transfer.
> There is a high probability to get the soft/hard lockup
> information if the driver continues to submit Rx before the HUB
> completes the detection of all hub ports and issue the
> disconnect event.

I don't think it is a good idea.
For the other situations which return the same error code, you would stop the rx, too.
However, the rx may re-work after being resubmitted for the other cases.

Best Regards,
Hayes