netdev - Re: [PATCH -next] net/ipv4/datagram.c: remove superfluous header files from datagram.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210928174104.4c05448e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 28 Sep 2021 17:41:04 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Mianhan Liu <liumh1@...nghaitech.edu.cn>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] net/ipv4/datagram.c: remove superfluous header
 files from datagram.c

On Wed, 29 Sep 2021 01:49:43 +0800 Mianhan Liu wrote:
> datagram.c hasn't use any macro or function declared in linux/ip.h,
> and linux/module.h.
> Thus, these files can be removed from datagram.c safely without
> affecting the compilation of the net/ipv4 module
> 
> Signed-off-by: Mianhan Liu <liumh1@...nghaitech.edu.cn>
> 
> ---
>  net/ipv4/datagram.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/ipv4/datagram.c b/net/ipv4/datagram.c
> index 4a8550c49..2dc5f1890 100644
> --- a/net/ipv4/datagram.c
> +++ b/net/ipv4/datagram.c
> @@ -8,8 +8,6 @@
>   */
>  
>  #include <linux/types.h>
> -#include <linux/module.h>

If we remove this one we need to add an include for linux/export.h

> -#include <linux/ip.h>

This indeed looks unnecessary.

>  #include <linux/in.h>
>  #include <net/ip.h>
>  #include <net/sock.h>