netdev - RE: [EXT] Re: [PATCH 04/12] qed: Update qed_mfw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR18MB1071B5034AD53DD075A0E1C4B2AA9@MWHPR18MB1071.namprd18.prod.outlook.com>
Date:   Thu, 30 Sep 2021 10:18:21 +0000
From:   Prabhakar Kushwaha <pkushwaha@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        Ariel Elior <aelior@...vell.com>,
        Shai Malin <smalin@...vell.com>,
        Javed Hasan <jhasan@...vell.com>,
        Manish Rangankar <mrangankar@...vell.com>,
        "prabhakar.pkin@...il.com" <prabhakar.pkin@...il.com>,
        "malin1024@...il.com" <malin1024@...il.com>,
        Omkar Kulkarni <okulkarni@...vell.com>
Subject: RE: [EXT] Re: [PATCH 04/12] qed: Update qed_mfw_hsi.h for FW ver
 8.59.1.0

Thanks Jakub for reviewing this patch series. 


> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Thursday, September 30, 2021 12:08 AM
> To: Prabhakar Kushwaha <pkushwaha@...vell.com>
> Cc: netdev@...r.kernel.org; davem@...emloft.net; linux-
> rdma@...r.kernel.org; linux-scsi@...r.kernel.org;
> martin.petersen@...cle.com; Ariel Elior <aelior@...vell.com>; Shai Malin
> <smalin@...vell.com>; Javed Hasan <jhasan@...vell.com>; Manish
> Rangankar <mrangankar@...vell.com>; prabhakar.pkin@...il.com;
> malin1024@...il.com; Omkar Kulkarni <okulkarni@...vell.com>
> Subject: [EXT] Re: [PATCH 04/12] qed: Update qed_mfw_hsi.h for FW ver
> 8.59.1.0
> 
> On Wed, 29 Sep 2021 15:12:07 +0300 Prabhakar Kushwaha wrote:
> > The qed_mfw_hsi.h contains HSI (Hardware Software Interface) changes
> > related to management firmware. It has been updated to support new FW
> > version 8.59.1.0 with below changes.
> >  - New defines for VF bitmap.
> >  - fec_mode and extended_speed defines updated in struct eth_phy_cfg.
> >  - Updated structutres lldp_system_tlvs_buffer_s, public_global,
> >    public_port, public_func, drv_union_data, public_drv_mb
> >    with all dependent new structures.
> >  - Updates in NVM related structures and defines.
> >  - Msg defines are added in enum drv_msg_code and fw_msg_code.
> >  - Updated/added new defines.
> >
> > This patch also fixes the existing checkpatch warnings and few important
> > checks.
> >
> > Signed-off-by: Ariel Elior <aelior@...vell.com>
> > Signed-off-by: Omkar Kulkarni <okulkarni@...vell.com>
> > Signed-off-by: Shai Malin <smalin@...vell.com>
> > Signed-off-by: Prabhakar Kushwaha <pkushwaha@...vell.com>
> 
> drivers/net/ethernet/qlogic/qed/qed_main.c:102:18: warning:
> ‘qed_mfw_ext_20g’ defined but not used [-Wunused-const-variable=]
>   102 | static const u32 qed_mfw_ext_20g[] __initconst = {
>       |                  ^~~~~~~~~~~~~~~
> 
> 
> Plus you add a whole bunch on kdoc warnings with those patches.
> Please make sure no new kdoc warnings and no new compilation warnings
> (with C=1 W=1 flags!)

Sorry from our side. 

Let me fix this and share v2 for review. 

--pk