netdev - RE: [Intel-wired-lan] [PATCH net v2] i40e: fix endless loop under rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW3PR11MB47484B86C8BE138AB4BA229FEBAA9@MW3PR11MB4748.namprd11.prod.outlook.com>
Date:   Thu, 30 Sep 2021 20:07:54 +0000
From:   "Switzer, David" <david.switzer@...el.com>
To:     Jiri Benc <jbenc@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH net v2] i40e: fix endless loop under
 rtnl

-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Jiri
>Benc
>Sent: Tuesday, September 14, 2021 1:55 AM
>To: netdev@...r.kernel.org
>Cc: intel-wired-lan@...ts.osuosl.org
>Subject: [Intel-wired-lan] [PATCH net v2] i40e: fix endless loop under rtnl
>
>The loop in i40e_get_capabilities can never end. The problem is that although
>i40e_aq_discover_capabilities returns with an error if there's a firmware
>problem, the returned error is not checked. There is a check for
>pf->hw.aq.asq_last_status but that value is set to I40E_AQ_RC_OK on most
>firmware problems.
>
>When i40e_aq_discover_capabilities encounters a firmware problem, it will
>enocunter the same problem on its next invocation. As the result, the loop
>becomes endless. We hit this with I40E_ERR_ADMIN_QUEUE_TIMEOUT but
>looking at the code, it can happen with a range of other firmware errors.
>
>I don't know what the correct behavior should be: whether the firmware
>should be retried a few times, or whether pf->hw.aq.asq_last_status should
>be always set to the encountered firmware error (but then it would be
>pointless and can be just replaced by the i40e_aq_discover_capabilities return
>value). However, the current behavior with an endless loop under the rtnl
>mutex(!) is unacceptable and Intel has not submitted a fix, although we
>explained the bug to them 7 months ago.
>
>This may not be the best possible fix but it's better than hanging the whole
>system on a firmware bug.
>
>Fixes: 56a62fc86895 ("i40e: init code and hardware support")
>Tested-by: Stefan Assmann <sassmann@...hat.com>
>Signed-off-by: Jiri Benc <jbenc@...hat.com>
Tested-by: Dave Switzer <david.switzer@...el.com>