netdev - Re: [RFCv2 net-next 019/167] net: sfc: convert the prototype of xxx_supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db183d34-e74a-aac9-57d6-81c35727787b@gmail.com>
Date:   Thu, 30 Sep 2021 01:28:24 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Jian Shen <shenjian15@...wei.com>, davem@...emloft.net,
        kuba@...nel.org, andrew@...n.ch, hkallweit1@...il.com
Cc:     netdev@...r.kernel.org, linuxarm@...neuler.org
Subject: Re: [RFCv2 net-next 019/167] net: sfc: convert the prototype of
 xxx_supported_features

On 29/09/2021 16:51, Jian Shen wrote:
> For the origin type for netdev_features_t would be changed to
> be unsigned long * from u64, so changes the prototype of
> xxx_supported_features for adaption.
> 
> Signed-off-by: Jian Shen <shenjian15@...wei.com>
> ---
>  drivers/net/ethernet/sfc/falcon/net_driver.h | 5 +++--
>  drivers/net/ethernet/sfc/mcdi_filters.c      | 5 ++++-
>  drivers/net/ethernet/sfc/net_driver.h        | 5 +++--
>  3 files changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/falcon/net_driver.h b/drivers/net/ethernet/sfc/falcon/net_driver.h
> index a381cf9ec4f3..6fabfe7f02f5 100644
> --- a/drivers/net/ethernet/sfc/falcon/net_driver.h
> +++ b/drivers/net/ethernet/sfc/falcon/net_driver.h
> @@ -1298,11 +1298,12 @@ static inline struct ef4_rx_buffer *ef4_rx_buffer(struct ef4_rx_queue *rx_queue,
>   * If a feature is fixed, it does not present in hw_features, but
>   * always in features.
>   */
> -static inline netdev_features_t ef4_supported_features(const struct ef4_nic *efx)
> +static inline void ef4_supported_features(const struct ef4_nic *efx,
> +					  netdev_features_t *supported)

Looks like this function isn't used anywhere in the Falcon
 code anyway, so you could just delete it instead.

-ed