netdev - Re: [net-next] devlink: report maximum number of snapshots with regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210930170506.24d74fb5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 30 Sep 2021 17:05:06 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>,
        Gurucharan G <gurucharanx.g@...el.com>
Subject: Re: [net-next] devlink: report maximum number of snapshots with
 regions

On Thu, 30 Sep 2021 14:21:04 -0700 Jacob Keller wrote:
> Each region has an independently configurable number of maximum
> snapshots. This information is not reported to userspace, making it not
> very discoverable. Fix this by adding a new
> DEVLINK_ATTR_REGION_MAX_SNAPSHOST attribute which is used to report this
> maximum.
> 
> Ex:
> 
>   $devlink region
>   pci/0000:af:00.0/nvm-flash: size 10485760 snapshot [] max 1
>   pci/0000:af:00.0/device-caps: size 4096 snapshot [] max 10
>   pci/0000:af:00.1/nvm-flash: size 10485760 snapshot [] max 1
>   pci/0000:af:00.1/device-caps: size 4096 snapshot [] max 10
> 
> This information enables users to understand why a new region command
> may fail due to having too many existing snapshots.
> 
> Reported-by: Gurucharan G <gurucharanx.g@...el.com> (A Contingent worker at Intel)
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>

Acked-by: Jakub Kicinski <kuba@...nel.org>