netdev - Re: [PATCH v2] rtl8xxxu: Use lower tx rates for the ack packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e64de376-f765-fc55-0e82-84e269c4dc43@gmail.com>
Date:   Fri, 1 Oct 2021 01:37:33 -0400
From:   Jes Sorensen <jes.sorensen@...il.com>
To:     Chris Chiu <chris.chiu@...onical.com>, kvalo@...eaurora.org,
        davem@...emloft.net, kuba@...nel.org
Cc:     code@...o-schneider.ch, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rtl8xxxu: Use lower tx rates for the ack packet

On 10/1/21 12:00 AM, Chris Chiu wrote:
> According to the Realtek propritary driver and the rtw88 driver, the
> tx rates of the ack (includes block ack) are initialized with lower
> tx rates (no HT rates) which is set by the RRSR register value. In
> real cases, ack rate higher than current tx rate could lead to
> difficulty for the receiving end to receive management/control frames.
> The retransmission rate would be higher then expected when the driver
> is acting as receiver and the RSSI is not good.
> 
> Cross out higer rates for ack packet before implementing dynamic rrsr
> configuration like the commit 4830872685f8 ("rtw88: add dynamic rrsr
> configuration").
> 
> Signed-off-by: Chris Chiu <chris.chiu@...onical.com>
> ---
> 
> Changelog:
>   v2:
>    - Specify the dynamic rrsr commit for reference
>    - Remove the unintentional twice reading of REG_RESPONSE_RATE_SET
> 
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 6 +++++-
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 2 ++
>  2 files changed, 7 insertions(+), 1 deletion(-)

Acked-by: Jes Sorensen <Jes.Sorensen@...il.com>