netdev - Re: [PATCH] dt-bindings: net: renesas,etheravb: Update example to match reality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVdIy9JF3et1DFT8@bismarck.dyn.berto.se>
Date:   Fri, 1 Oct 2021 19:43:39 +0200
From:   Niklas Söderlund 
        <niklas.soderlund@...natech.se>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Sergey Shtylyov <s.shtylyov@....ru>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: net: renesas,etheravb: Update example to
 match reality

Hi Geert,

Thanks for your patch.

On 2021-10-01 14:13:55 +0200, Geert Uytterhoeven wrote:
>   - Add missing clock-names property,
>   - Add example compatible values for PHY subnode.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

> ---
>  Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> index 4c927d2c17d35d1b..bda821065a2b631f 100644
> --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> @@ -287,6 +287,7 @@ examples:
>                                "ch13", "ch14", "ch15", "ch16", "ch17", "ch18",
>                                "ch19", "ch20", "ch21", "ch22", "ch23", "ch24";
>              clocks = <&cpg CPG_MOD 812>;
> +            clock-names = "fck";
>              iommus = <&ipmmu_ds0 16>;
>              power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
>              resets = <&cpg 812>;
> @@ -298,6 +299,8 @@ examples:
>              #size-cells = <0>;
>  
>              phy0: ethernet-phy@0 {
> +                    compatible = "ethernet-phy-id0022.1622",
> +                                 "ethernet-phy-ieee802.3-c22";
>                      rxc-skew-ps = <1500>;
>                      reg = <0>;
>                      interrupt-parent = <&gpio2>;
> -- 
> 2.25.1
> 

-- 
Regards,
Niklas Söderlund