netdev - Re: [PATCH bpf-next v6 4/9] tools: Allow specifying base BTF file in resolve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbQ9FrUA1+5-dhg8Qd--XZYiSYXjMVEZAVh6Smj05vX6A@mail.gmail.com>
Date:   Fri, 1 Oct 2021 14:11:11 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Kumar Kartikeya Dwivedi <memxor@...il.com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next v6 4/9] tools: Allow specifying base BTF file in resolve_btfids

On Wed, Sep 29, 2021 at 11:30 PM Kumar Kartikeya Dwivedi
<memxor@...il.com> wrote:
>
> This commits allows specifying the base BTF for resolving btf id
> lists/sets during link time in the resolve_btfids tool. The base BTF is
> set to NULL if no path is passed. This allows resolving BTF ids for
> module kernel objects.
>
> Also, drop the --no-fail option, as it is only used in case .BTF_ids
> section is not present, instead make no-fail the default mode. The long
> option name is same as that of pahole.
>
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@...il.com>
> ---

LGTM.

Acked-by: Andrii Nakryiko <andrii@...nel.org>

>  tools/bpf/resolve_btfids/main.c      | 28 +++++++++++++++++++---------
>  tools/testing/selftests/bpf/Makefile |  2 +-
>  2 files changed, 20 insertions(+), 10 deletions(-)
>

[...]