netdev - Re: [PATCH 1/3] net: phy: mscc: Add possibilty to disable combined LED mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18de5e10-f41f-0790-89c8-3a70d48539be@kontron.de>
Date:   Fri, 1 Oct 2021 11:20:36 +0200
From:   Frieder Schrempf <frieder.schrempf@...tron.de>
To:     Andrew Lunn <andrew@...n.ch>, Frieder Schrempf <frieder@...s.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org,
        Bjarni Jonasson <bjarni.jonasson@...rochip.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Russell King <linux@...linux.org.uk>,
        Steen Hegelund <steen.hegelund@...rochip.com>,
        Marek Behún <marek.behun@....cz>
Subject: Re: [PATCH 1/3] net: phy: mscc: Add possibilty to disable combined
 LED mode

On 01.10.21 02:05, Andrew Lunn wrote:
> On Thu, Sep 30, 2021 at 02:57:43PM +0200, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@...tron.de>
>>
>> By default the LED modes offer to combine two indicators like speed/link
>> and activity in one LED. In order to use a LED only for the first of the
>> two modes, the combined feature needs to be disabled.
>>
>> In order to do this we introduce a boolean devicetree property
>> 'vsc8531,led-[N]-combine-disable' and wire it up to the matching
>> bits in the LED behavior register.
> 
> Sorry, but no DT property. Each PHY has its own magic combination of
> DT properties, nothing shared, nothing common. This does not scale.
> 
> Please look at the work being done to control PHY LEDs using the Linux
> LED infrastructure. That should give us one uniform interface for all
> PHY LEDs.

+Cc: Marek

I guess you are referring to this: [1]?

If so, the last version I could find is a year old now. Is anyone still
working on this?

I understand, that the generic approach is the one we want to have, but
does this really mean adding PHY led configuration via DT to existing
drivers (that already use DT properties for LED modes) is not accepted
anymore, even if the new API is not yet in place?

If anyone (Marek?) would be willing to revive this series, I could maybe
try to find some spare time to rework the mscc PHY LED configuration on
top of this and do some tests.

[1] https://patches.linaro.org/patch/255422/