netdev - Re: [kbuild-all] Re: [PATCH bpf-next v3 06/10] xsk: propagate napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211002020737.GE26462@rli9-MOBL1.ccr.corp.intel.com>
Date:   Sat, 2 Oct 2021 10:07:37 +0800
From:   Philip Li <philip.li@...el.com>
To:     Magnus Karlsson <magnus.karlsson@...il.com>
Cc:     kernel test robot <lkp@...el.com>,
        Björn Töpel <bjorn.topel@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, kbuild-all@...ts.01.org,
        Björn Töpel <bjorn.topel@...el.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Zhang, Qi Z" <qi.z.zhang@...el.com>
Subject: Re: [kbuild-all] Re: [PATCH bpf-next v3 06/10] xsk: propagate
 napi_id to XDP socket Rx path

On Thu, Sep 30, 2021 at 08:04:06AM +0200, Magnus Karlsson wrote:
> On Wed, Sep 29, 2021 at 8:37 PM kernel test robot <lkp@...el.com> wrote:
> >
> > Hi "Björn,
> >
> > I love your patch! Yet something to improve:
> >
> > [auto build test ERROR on 4e99d115d865d45e17e83478d757b58d8fa66d3c]
> >
> > url:    https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Introduce-preferred-busy-polling/20210929-234934
> > base:   4e99d115d865d45e17e83478d757b58d8fa66d3c
> > config: um-kunit_defconfig (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> > reproduce (this is a W=1 build):
> >         # https://github.com/0day-ci/linux/commit/f481c00164924dd5d782a92cc67897cc7f804502
> >         git remote add linux-review https://github.com/0day-ci/linux
> >         git fetch --no-tags linux-review Bj-rn-T-pel/Introduce-preferred-busy-polling/20210929-234934
> >         git checkout f481c00164924dd5d782a92cc67897cc7f804502
> >         # save the attached .config to linux build tree
> >         mkdir build_dir
> >         make W=1 O=build_dir ARCH=um SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@...el.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >    cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs]
> >    In file included from fs/select.c:32:
> >    include/net/busy_poll.h: In function 'sk_mark_napi_id_once':
> > >> include/net/busy_poll.h:150:36: error: 'const struct sk_buff' has no member named 'napi_id'
> >      150 |  __sk_mark_napi_id_once_xdp(sk, skb->napi_id);
> >          |                                    ^~
> >
> >
> > vim +150 include/net/busy_poll.h
> >
> >    145
> >    146  /* variant used for unconnected sockets */
> >    147  static inline void sk_mark_napi_id_once(struct sock *sk,
> >    148                                          const struct sk_buff *skb)
> >    149  {
> >  > 150          __sk_mark_napi_id_once_xdp(sk, skb->napi_id);
> >    151  }
> >    152
> 
> It seems that the robot tested an old commit and that this was already
> fixed by Daniel 10 months ago. Slow mail delivery, a robot glitch, or
> am I missing something?
sorry for the noise, we got storage crash and it seems to have old data
back in test queue after recovery. We will do cleanup to avoid this kind
of old commit being tested.

> 
> commit ba0581749fec389e55c9d761f2716f8fcbefced5
> Author: Daniel Borkmann <daniel@...earbox.net>
> Date:   Tue Dec 1 15:22:59 2020 +0100
> 
>     net, xdp, xsk: fix __sk_mark_napi_id_once napi_id error
> 
>     Stephen reported the following build error for !CONFIG_NET_RX_BUSY_POLL
>     built kernels:
> 
>       In file included from fs/select.c:32:
>       include/net/busy_poll.h: In function 'sk_mark_napi_id_once':
>       include/net/busy_poll.h:150:36: error: 'const struct sk_buff'
> has no member named 'napi_id'
>         150 |  __sk_mark_napi_id_once_xdp(sk, skb->napi_id);
>             |                                    ^~
> 
>     Fix it by wrapping a CONFIG_NET_RX_BUSY_POLL around the helpers.
> 
>     Fixes: b02e5a0ebb17 ("xsk: Propagate napi_id to XDP socket Rx path")
>     Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
>     Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
>     Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
>     Cc: Björn Töpel <bjorn.topel@...el.com>
>     Link: https://lore.kernel.org/linux-next/20201201190746.7d3357fb@canb.auug.org.au
> 
> 
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@...ts.01.org
> To unsubscribe send an email to kbuild-all-leave@...ts.01.org