netdev - Re: [PATCH] net:dev: Change napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d21e758966ca5581edd4babe0773a28e9938a78.camel@perches.com>
Date:   Sat, 02 Oct 2021 00:22:04 -0700
From:   Joe Perches <joe@...ches.com>
To:     Gyumin Hwang <hkm73560@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Antoine Tenart <atenart@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] net:dev: Change napi_gro_complete return type to void

On Sat, 2021-10-02 at 06:11 +0000, Gyumin Hwang wrote:
> napi_gro_complete always returned the same value, NET_RX_SUCCESS
> And the value was not used anywhere
[]
> diff --git a/net/core/dev.c b/net/core/dev.c
[]
> @@ -5868,12 +5868,12 @@ static int napi_gro_complete(struct napi_struct *napi, struct sk_buff *skb)
>  	if (err) {
>  		WARN_ON(&ptype->list == head);
>  		kfree_skb(skb);
> -		return NET_RX_SUCCESS;
> +		return;
>  	}
>  
> 
>  out:
>  	gro_normal_one(napi, skb, NAPI_GRO_CB(skb)->count);
> -	return NET_RX_SUCCESS;
> +	return;

unnecessary return at function end

>  }