netdev - Re: [PATCH net-next 03/11] ethernet: use eth_hw_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YViJtfwpSqR9wIOU@shredder>
Date:   Sat, 2 Oct 2021 19:32:53 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 03/11] ethernet: use eth_hw_addr_set()

On Fri, Oct 01, 2021 at 02:32:20PM -0700, Jakub Kicinski wrote:
> Convert all Ethernet drivers from memcpy(... ETH_ADDR)
> to eth_hw_addr_set():
> 
>   @@
>   expression dev, np;
>   @@
>   - memcpy(dev->dev_addr, np, ETH_ALEN)
>   + eth_hw_addr_set(dev, np)

Some use:

memcpy(dev->dev_addr, np, dev->addr_len)

Not sure if you missed it or if it's going to be in part 2. I assume the
latter, but thought I would ask.

Thanks