netdev - Re: [PATCH] unix.7: Add a description for ENFILE.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <206a26e5-0515-44b9-39cb-bc46013bfc6c@gmail.com>
Date:   Sat, 2 Oct 2021 19:44:52 +0200
From:   "Alejandro Colomar (man-pages)" <alx.manpages@...il.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.co.jp>
Cc:     Benjamin Herrenschmidt <benh@...zon.com>,
        Kuniyuki Iwashima <kuni1840@...il.com>,
        linux-man@...r.kernel.org, netdev@...r.kernel.org,
        Michael Kerrisk <mtk.manpages@...il.com>
Subject: Re: [PATCH] unix.7: Add a description for ENFILE.

Hello Kuniyuki,

On 9/29/21 3:38 AM, Kuniyuki Iwashima wrote:
> When creating UNIX domain sockets, the kernel used to return -ENOMEM on
> error where it should return -ENFILE.  The behaviour has been wrong since
> 2.2.4 and fixed in the recent commit f4bd73b5a950 ("af_unix: Return errno
> instead of NULL in unix_create1().").
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.co.jp>
> ---
> Note to maintainers of man-pages, the commit is merged in the net tree [0]
> but not in the Linus' tree yet.
> 
> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=f4bd73b5a950

Thanks!

The patch looks good to me, so could you ping back when this is merged 
in Linus's tree?

Cheers,

Alex

> ---
>   man7/unix.7 | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/man7/unix.7 b/man7/unix.7
> index 6d30b25cd..2dc96fea1 100644
> --- a/man7/unix.7
> +++ b/man7/unix.7
> @@ -721,6 +721,9 @@ invalid state for the applied operation.
>   called on an already connected socket or a target address was
>   specified on a connected socket.
>   .TP
> +.B ENFILE
> +The system-wide limit on the total number of open files has been reached.
> +.TP
>   .B ENOENT
>   The pathname in the remote address specified to
>   .BR connect (2)
> 


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/