lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 2 Oct 2021 23:33:03 +0200 From: Andreas Rammhold <andreas@...mhold.de> To: Jakub Kicinski <kuba@...nel.org> Cc: Heiko Stübner <heiko@...ech.de>, netdev@...r.kernel.org, Punit Agrawal <punitagrawal@...il.com>, linux-rockchip@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, davem@...emloft.net, peppe.cavallaro@...com, alexandre.torgue@...s.st.com, Michael Riesch <michael.riesch@...fvision.net> Subject: Re: [PATCH] net: stmmac: dwmac-rk: Fix ethernet on rk3399 based devices On 16:02 01.10.21, Jakub Kicinski wrote: > On Wed, 29 Sep 2021 23:02:35 +0200 Heiko Stübner wrote: > > Am Mittwoch, 29. September 2021, 15:50:49 CEST schrieb Punit Agrawal: > > > Commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings") > > > while getting rid of a runtime PM warning ended up breaking ethernet > > > on rk3399 based devices. By dropping an extra reference to the device, > > > the commit ends up enabling suspend / resume of the ethernet device - > > > which appears to be broken. > > > > > > While the issue with runtime pm is being investigated, partially > > > revert commit 2d26f6e39afb to restore the network on rk3399. > > > > > > Fixes: 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings") > > > Suggested-by: Heiko Stuebner <heiko@...ech.de> > > > Signed-off-by: Punit Agrawal <punitagrawal@...il.com> > > > Cc: Michael Riesch <michael.riesch@...fvision.net> > > > > On a rk3399-puma which has the described issue, > > Tested-by: Heiko Stuebner <heiko@...ech.de> > > Applied, thanks! This also fixed the issue on a RockPi4. Will any of you submit this to the stable kernels (as this broke within 3.13 for me) or shall I do that?
Powered by blists - more mailing lists