netdev - RE: [PATCH v4] skmsg: lose offset info in sk_psock_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Oct 2021 04:27:34 +0000
From:   "liujian (CE)" <liujian56@...wei.com>
To:     John Fastabend <john.fastabend@...il.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "jakub@...udflare.com" <jakub@...udflare.com>,
        "lmb@...udflare.com" <lmb@...udflare.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "ast@...nel.org" <ast@...nel.org>,
        "andrii@...nel.org" <andrii@...nel.org>,
        "kafai@...com" <kafai@...com>,
        "songliubraving@...com" <songliubraving@...com>,
        "yhs@...com" <yhs@...com>,
        "kpsingh@...nel.org" <kpsingh@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>
Subject: RE: [PATCH v4] skmsg: lose offset info in sk_psock_skb_ingress



> -----Original Message-----
> From: John Fastabend [mailto:john.fastabend@...il.com]
> Sent: Friday, October 1, 2021 6:48 AM
> To: liujian (CE) <liujian56@...wei.com>; john.fastabend@...il.com;
> daniel@...earbox.net; jakub@...udflare.com; lmb@...udflare.com;
> davem@...emloft.net; kuba@...nel.org; ast@...nel.org;
> andrii@...nel.org; kafai@...com; songliubraving@...com; yhs@...com;
> kpsingh@...nel.org; netdev@...r.kernel.org; bpf@...r.kernel.org;
> xiyou.wangcong@...il.com
> Cc: liujian (CE) <liujian56@...wei.com>
> Subject: RE: [PATCH v4] skmsg: lose offset info in sk_psock_skb_ingress
>
> Liu Jian wrote:
> > If sockmap enable strparser, there are lose offset info in
> > sk_psock_skb_ingress. If the length determined by parse_msg function
> > is not skb->len, the skb will be converted to sk_msg multiple times,
> > and userspace app will get the data multiple times.
> >
> > Fix this by get the offset and length from strp_msg.
> > And as Cong suggestion, add one bit in skb->_sk_redir to distinguish
> > enable or disable strparser.
> >
> > Signed-off-by: Liu Jian <liujian56@...wei.com>
> > ---
>
> Thanks. Please add Fixes tags so we can track these I've added it here.
>
> This has been broken from the initial patches and after a quick glance I
> suspect this will need manual backports if we need it. Also all the I use and all
> the selftests set parser to a nop by returning skb->len.
>
> Can you also create a test so we can ensure we don't break this again?
Okay, I will do this after the holiday.
>
> Fixes: 604326b41a6fb ("bpf, sockmap: convert to generic sk_msg interface")
> Acked-by: John Fastabend <john.fastabend@...il.com>
Thank you for reviewing this patch again.