netdev - Re: [PATCH iproute2-next] ip: nexthop: keep cache netlink socket open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <016dbae1-3a80-e731-d056-3a23ad2f7265@gmail.com>
Date:   Tue, 5 Oct 2021 08:35:04 -0600
From:   David Ahern <dsahern@...il.com>
To:     Nikolay Aleksandrov <razor@...ckwall.org>, netdev@...r.kernel.org
Cc:     roopa@...dia.com, Nikolay Aleksandrov <nikolay@...dia.com>
Subject: Re: [PATCH iproute2-next] ip: nexthop: keep cache netlink socket open

On 10/4/21 3:03 AM, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@...dia.com>
> 
> Since we use the cache netlink socket for each nexthop we can keep it open
> instead of opening and closing it on every add call. The socket is opened
> once, on the first add call and then reused for the rest.
> 
> Suggested-by: David Ahern <dsahern@...il.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...dia.com>
> ---
> I actually had this in my initial patchset, but switched it with the
> open/close on each call. TBH, I don't recall why, perhaps to be the same
> as the link cache. I don't see a reason not to keep the socket open.
> 
> I've re-run the stress test and the selftests, all look good.
> 
>  ip/ipnexthop.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 

applied to iproute2-next. Thanks,