netdev - Re: [PATCH net-next 2/2] net: phylink: use mdiobus_modify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211005092601.7029f2d0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 5 Oct 2021 09:26:01 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Sean Anderson <sean.anderson@...o.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: phylink: use mdiobus_modify_changed()
 helper

On Tue, 05 Oct 2021 16:34:02 +0100 Russell King (Oracle) wrote:
> Use the mdiobus_modify_changed() helper in the C22 PCS advertisement
> helper.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/phy/phylink.c | 28 ++++------------------------
>  1 file changed, 4 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index b32774fd65f8..d76362028752 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c

drivers/net/phy/phylink.c: In function ‘phylink_mii_c22_pcs_set_advertisement’:
drivers/net/phy/phylink.c:2599:11: warning: unused variable ‘ret’ [-Wunused-variable]
 2599 |  int val, ret;
      |           ^~~
drivers/net/phy/phylink.c:2599:6: warning: unused variable ‘val’ [-Wunused-variable]
 2599 |  int val, ret;
      |      ^~~