netdev - Re: [PATCH net-next 1/4] of: net: add a helper for loading netdev->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211005092956.44eb4d3d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 5 Oct 2021 09:29:56 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Frank Rowand <frowand.list@...il.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 1/4] of: net: add a helper for loading
 netdev->dev_addr

On Tue, 5 Oct 2021 11:15:48 -0500 Rob Herring wrote:
> On Tue, Oct 5, 2021 at 10:53 AM Jakub Kicinski <kuba@...nel.org> wrote:
> > Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
> > of VLANs...") introduced a rbtree for faster Ethernet address look
> > up. To maintain netdev->dev_addr in this tree we need to make all
> > the writes to it got through appropriate helpers.
> >
> > There are roughly 40 places where netdev->dev_addr is passed
> > as the destination to a of_get_mac_address() call. Add a helper
> > which takes a dev pointer instead, so it can call an appropriate
> > helper.
> >
> > Note that of_get_mac_address() already assumes the address is
> > 6 bytes long (ETH_ALEN) so use eth_hw_addr_set().
> >
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > ---
> >  drivers/of/of_net.c    | 25 +++++++++++++++++++++++++  
> 
> Can we move this file to drivers/net/ given it's always merged via the
> net tree? It's also the only thing left not part of the driver
> subsystems.

Hm, our driver core historically lives under net/core, not drivers/net,
how about drivers/of/of_net.c -> net/core/of_net.c ?