netdev - Re: [PATCH] [v18 2/2] wireless: Initial driver submission for pureLiFi STA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c051f7f8-132c-59dd-717d-11d590ddecb0@codeaurora.org>
Date:   Tue, 5 Oct 2021 15:09:58 -0700
From:   Jeff Johnson <jjohnson@...eaurora.org>
To:     Srinivasan Raju <srini.raju@...elifi.com>
Cc:     mostafa.afgani@...elifi.com, Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:NETWORKING DRIVERS (WIRELESS)" 
        <linux-wireless@...r.kernel.org>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>
Subject: Re: [PATCH] [v18 2/2] wireless: Initial driver submission for
 pureLiFi STA devices

On 10/5/2021 5:31 AM, Srinivasan Raju wrote:> +		fw_data = 
kmemdup(&fw->data[fw_data_i], blk_tran_len,> +				  GFP_KERNEL);> +> +	 
for (tbuf_idx = 0; tbuf_idx < blk_tran_len; tbuf_idx++) {> +			/* u8 bit 
reverse */> +			fw_data[tbuf_idx] = bitrev8(fw_data[tbuf_idx]);> +		}
note kmemdup() can return NULL, hence the reference to fw_data[] can 
dereference NULL.