netdev - Re: [PATCH v1 net-next 1/1] net: Mark possible unused variables on stack with __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211004182410.3f3496b9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 4 Oct 2021 18:24:10 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        "Jose M. Guisado Gomez" <guigom@...eup.net>,
        "David S. Miller" <davem@...emloft.net>,
        Arnd Bergmann <arnd@...db.de>, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH v1 net-next 1/1] net: Mark possible unused variables on
 stack with __maybe_unused

On Fri,  1 Oct 2021 17:50:56 +0300 Andy Shevchenko wrote:
> When compile with COMPILE_TEST=y the -Werror is implied.
> If we run `make W=1` the first level warnings will become
> the build errors. Some of them related to possible unused
> variables. Hence, to allow clean build in such case, mark
> them with __maybe_unused.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

You need to split the socket and fib change from the netfilter ones.
Those go via different sub-trees.