netdev - Re: [PATCH v7 08/24] wfx: add bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 05 Oct 2021 08:59:47 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Jérôme Pouiller <jerome.pouiller@...abs.com>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        driverdevel <devel@...verdev.osuosl.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S . Miller" <davem@...emloft.net>,
        DTML <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH v7 08/24] wfx: add bus_sdio.c

Ulf Hansson <ulf.hansson@...aro.org> writes:

>> > > +static const struct sdio_device_id wfx_sdio_ids[] = {
>> > > +       { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) },
>> > > +       { },
>> > > +};
>> > > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids);
>> > > +
>> > > +struct sdio_driver wfx_sdio_driver = {
>> > > +       .name = "wfx-sdio",
>> > > +       .id_table = wfx_sdio_ids,
>> > > +       .probe = wfx_sdio_probe,
>> > > +       .remove = wfx_sdio_remove,
>> > > +       .drv = {
>> > > +               .owner = THIS_MODULE,
>> > > +               .of_match_table = wfx_sdio_of_match,
>> >
>> > Is there no power management? Or do you intend to add that on top?
>>
>> It seems we already have had this discussion:
>>
>>   https://lore.kernel.org/netdev/CAPDyKFqJf=vUqpQg3suDCadKrFTkQWFTY_qp=+yDK=_Lu9gJGg@mail.gmail.com/#r
>>
>> In this thread, Kalle said:
>> > Many mac80211 drivers do so that the device is powered off during
>> > interface down (ifconfig wlan0 down), and as mac80211 does interface
>> > down automatically during suspend, suspend then works without extra
>> > handlers.
>
> Yeah, it's been a while since I looked at this, thanks for the pointer.

I want to emphasize that what I said above was just a generic comment
about mac80211 drivers and just trying to give some ideas how to solve
this, I did not check how wfx driver behaves in this regard.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches