netdev - Re: [PATCH bpf-next v7 0/9] Support kernel module function calls from eBPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQKDPG+U-NwoAeNSU5Ef9ZYhhGcgL4wBkFoP-E9h8-XZhw@mail.gmail.com>
Date:   Tue, 5 Oct 2021 17:17:34 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Kumar Kartikeya Dwivedi <memxor@...il.com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next v7 0/9] Support kernel module function calls from eBPF

On Fri, Oct 1, 2021 at 6:18 PM Kumar Kartikeya Dwivedi <memxor@...il.com> wrote:
>
> This set enables kernel module function calls, and also modifies verifier logic
> to permit invalid kernel function calls as long as they are pruned as part of
> dead code elimination. This is done to provide better runtime portability for
> BPF objects, which can conditionally disable parts of code that are pruned later
> by the verifier (e.g. const volatile vars, kconfig options). libbpf
> modifications are made along with kernel changes to support module function
> calls.
>
> It also converts TCP congestion control objects to use the module kfunc support
> instead of relying on IS_BUILTIN ifdef.
>
> Changelog:
> ----------
> v6 -> v7
> v6: https://lore.kernel.org/bpf/20210930062948.1843919-1-memxor@gmail.com
>
>  * Let __bpf_check_kfunc_call take kfunc_btf_id_list instead of generating
>    callbacks (Andrii)
>  * Rename it to bpf_check_mod_kfunc_call to reflect usage
>  * Remove OOM checks (Alexei)
>  * Remove resolve_btfids invocation for bpf_testmod (Andrii)
>  * Move fd_array_cnt initialization near fd_array alloc (Andrii)
>  * Rename helper to btf_find_by_name_kind and pass start_id (Andrii)
>  * memset when data is NULL in add_data (Alexei)
>  * Fix other nits

Looking good now. Applied. Thanks