netdev - Re: [net-next PATCH 1/3] octeontx2-pf: Simplify the receive buffer size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211005181147.3481f702@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 5 Oct 2021 18:11:47 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Subbaraya Sundeep <sbhatta@...vell.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <sgoutham@...vell.com>, <hkelam@...vell.com>, <gakula@...vell.com>
Subject: Re: [net-next PATCH 1/3] octeontx2-pf: Simplify the receive buffer
 size calculation

On Tue, 5 Oct 2021 22:45:34 +0530 Subbaraya Sundeep wrote:
> This patch separates the logic of configuring hardware
> maximum transmit frame size and receive frame size.
> This simplifies the logic to calculate receive buffer
> size and using cqe descriptor of different size.
> Also additional size of skb_shared_info structure is
> allocated for each receive buffer pointer given to
> hardware which is not necessary. Hence change the
> size calculation to remove the size of
> skb_shared_info. Add a check for array out of
> bounds while adding fragments to the network stack.

drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c:91:54: error: ‘struct otx2_nic’ has no member named ‘max_frs’
   91 |  aq->sq.smq_rr_weight = mtu_to_dwrr_weight(pfvf, pfvf->max_frs);
      |                                                      ^~