netdev - Re: [PATCH iproute2 v3 1/3] configure: support --param=value style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Oct 2021 12:18:57 +0200
From:   Phil Sutter <phil@....cc>
To:     Andrea Claudi <aclaudi@...hat.com>
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org,
        dsahern@...il.com, bluca@...ian.org
Subject: Re: [PATCH iproute2 v3 1/3] configure: support --param=value style

Hi Andrea,

On Wed, Oct 06, 2021 at 11:49:34AM +0200, Andrea Claudi wrote:
[...]
> That was my first proposal in v1 [1]. I changed it on David's suggestion
> to consolidate the two cases into a single one.

Oh, sorry. I missed the 'v3' tag and hence didn't check any earlier
version.

> Looking at the resulting code, v3 code results in an extra check to
> discriminate between the two use cases, while v0 uses the "case"
> structure to the same end.

Given that David explicitly requested the change I'm complaining about
in his reply to your initial version, I guess any further debate about
it is irrelevant.

Thanks, Phil