netdev - Re: [PATCH 01/11] selftests: net/fcnal: Fix {ipv4,ipv6}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a09f8b5-1507-ca00-74d1-d6a1d8b848bf@gmail.com>
Date:   Wed, 6 Oct 2021 08:37:27 -0600
From:   David Ahern <dsahern@...il.com>
To:     Leonard Crestez <cdleonard@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Shuah Khan <shuah@...nel.org>, David Ahern <dsahern@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Ido Schimmel <idosch@...dia.com>,
        Seth David Schoen <schoen@...alty.org>,
        netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/11] selftests: net/fcnal: Fix {ipv4,ipv6}_bind not run
 by default

On 10/6/21 5:47 AM, Leonard Crestez wrote:
> Inside the TESTS_IPV{4,6} array these are listed as ipv{4,6}_addr_bind
> but test running loop only checks for ipv{4,6}_bind and bind{,6} and
> ignores everything else.
> 
> As a consequence these tests were not run by default, only with an
> explicit -t.
> 
> Fix inside TESTS_IPV{4,6}.
> 
> Signed-off-by: Leonard Crestez <cdleonard@...il.com>
> ---
>  tools/testing/selftests/net/fcnal-test.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Good catch.

Reviewed-by: David Ahern <dsahern@...nel.org>