netdev - Re: [RFC] fwnode: change the return type of mac address helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YV23gINkk3b9m6tb@lunn.ch>
Date:   Wed, 6 Oct 2021 16:49:36 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, gregkh@...uxfoundation.org,
        rafael@...nel.org, saravanak@...gle.com, mw@...ihalf.com,
        jeremy.linton@....com
Subject: Re: [RFC] fwnode: change the return type of mac address helpers

> --- a/drivers/net/ethernet/apm/xgene-v2/main.c
> +++ b/drivers/net/ethernet/apm/xgene-v2/main.c
> @@ -36,7 +36,7 @@ static int xge_get_resources(struct xge_pdata *pdata)
>  		return -ENOMEM;
>  	}
>  
> -	if (!device_get_ethdev_addr(dev, ndev))
> +	if (device_get_ethdev_addr(dev, ndev))
>  		eth_hw_addr_random(ndev);

That is going to be interesting for out of tree drivers.

Otherwise, this looks O.K.

	   Andrew