netdev - RE: [RFC 08/12] ravb: Add carrier_counters to struct ravb_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS0PR01MB592250A67A4E5BFFF02DD49D86B09@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Wed, 6 Oct 2021 17:22:47 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Sergey Shtylyov <s.shtylyov@...russia.ru>,
        Adam Ford <aford173@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Yuusuke Ashizuka <ashiduka@...itsu.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: RE: [RFC 08/12] ravb: Add carrier_counters to struct ravb_hw_info

Hi Sergey,

> Subject: Re: [RFC 08/12] ravb: Add carrier_counters to struct ravb_hw_info
> 
> On 10/6/21 7:41 PM, Sergey Shtylyov wrote:
> 
> >> RZ/G2L E-MAC supports carrier counters.
> >> Add a carrier_counter hw feature bit to struct ravb_hw_info to add
> >> this feature only for RZ/G2L.
> >>
> >> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> >> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
> >
> > [...]
> >
> >> diff --git a/drivers/net/ethernet/renesas/ravb.h
> >> b/drivers/net/ethernet/renesas/ravb.h
> >> index 8c7b2569c7dd..899e16c5eb1a 100644
> >> --- a/drivers/net/ethernet/renesas/ravb.h
> >> +++ b/drivers/net/ethernet/renesas/ravb.h
> >> [...]
> >> @@ -1061,6 +1065,7 @@ struct ravb_hw_info {
> >>  	unsigned nc_queue:1;		/* AVB-DMAC has NC queue */
> >>  	unsigned magic_pkt:1;		/* E-MAC supports magic packet
> detection */
> >>  	unsigned half_duplex:1;		/* E-MAC supports half duplex mode */
> >> +	unsigned carrier_counters:1;	/* E-MAC has carrier counters */
> 
>    I thought I'd typed here that this field should be declared next to the
> 'tx_counters' field. :-)

Agreed. Will move to 'tx_counters' field.

Regards,
Biju