netdev - Re: [PATCH net-next v2 7/9] eth: fwnode: add a helper for loading netdev->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ff9c36a-3c66-b244-8b2a-7eb4e2cc2d05@pensando.io>
Date:   Wed, 6 Oct 2021 11:13:28 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, gregkh@...uxfoundation.org,
        rafael@...nel.org, saravanak@...gle.com, mw@...ihalf.com,
        andrew@...n.ch, jeremy.linton@....com, hkallweit1@...il.com,
        linux@...linux.org.uk, robh+dt@...nel.org, frowand.list@...il.com,
        heikki.krogerus@...ux.intel.com, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v2 7/9] eth: fwnode: add a helper for loading
 netdev->dev_addr



On 10/6/21 8:44 AM, Jakub Kicinski wrote:
> Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
> of VLANs...") introduced a rbtree for faster Ethernet address look
> up. To maintain netdev->dev_addr in this tree we need to make all
> the writes to it got through appropriate helpers.
>
> There is a handful of drivers which pass netdev->dev_addr as
> the destination buffer to device_get_mac_address(). Add a helper
> which takes a dev pointer instead, so it can call an appropriate
> helper.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> v2: spell out address instead of addr in the function name
> ---
>   include/linux/etherdevice.h |  1 +
>   include/linux/property.h    |  1 +
>   net/ethernet/eth.c          | 20 ++++++++++++++++++++
>   3 files changed, 22 insertions(+)
>
> diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
> index 32c30d0f7a73..e75116f48cd1 100644
> --- a/include/linux/etherdevice.h
> +++ b/include/linux/etherdevice.h
> @@ -32,6 +32,7 @@ int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr);
>   unsigned char *arch_get_platform_mac_address(void);
>   int nvmem_get_mac_address(struct device *dev, void *addrbuf);
>   int device_get_mac_address(struct device *dev, char *addr);
> +int device_get_ethdev_address(struct device *dev, struct net_device *netdev);
>   int fwnode_get_mac_address(struct fwnode_handle *fwnode, char *addr);
>   
>   u32 eth_get_headlen(const struct net_device *dev, const void *data, u32 len);
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 4fb081684255..88fa726a76df 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -15,6 +15,7 @@
>   #include <linux/types.h>
>   
>   struct device;
> +struct net_device;
>   
>   enum dev_prop_type {
>   	DEV_PROP_U8,
> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
> index 29447a61d3ec..5441b232d8a4 100644
> --- a/net/ethernet/eth.c
> +++ b/net/ethernet/eth.c
> @@ -617,3 +617,23 @@ int device_get_mac_address(struct device *dev, char *addr)
>   	return fwnode_get_mac_address(dev_fwnode(dev), addr);
>   }
>   EXPORT_SYMBOL(device_get_mac_address);
> +
> +/**
> + * device_get_ethdev_addr - Set netdev's MAC address from a given device

Nit: s/_addr/_address/

sln

> + * @dev:	Pointer to the device
> + * @netdev:	Pointer to netdev to write the address to
> + *
> + * Wrapper around device_get_mac_address() which writes the address
> + * directly to netdev->dev_addr.
> + */
> +int device_get_ethdev_address(struct device *dev, struct net_device *netdev)
> +{
> +	u8 addr[ETH_ALEN];
> +	int ret;
> +
> +	ret = device_get_mac_address(dev, addr);
> +	if (!ret)
> +		eth_hw_addr_set(netdev, addr);
> +	return ret;
> +}
> +EXPORT_SYMBOL(device_get_ethdev_address);