netdev - RE: [RFC 12/12] ravb: Update/Add comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS0PR01MB5922A21D4274A5E3941A1E2886B09@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Wed, 6 Oct 2021 06:53:28 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Sergey Shtylyov <s.shtylyov@...russia.ru>,
        Adam Ford <aford173@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Yuusuke Ashizuka <ashiduka@...itsu.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: RE: [RFC 12/12] ravb: Update/Add comments

Hi Sergei,

> Subject: Re: [RFC 12/12] ravb: Update/Add comments
> 
> On 10/5/21 2:06 PM, Biju Das wrote:
> 
> > This patch update/add the following comments
> >
> > 1) Fix the typo AVB->DMAC in comment, as the code following the comment
> >    is for GbEthernet DMAC in ravb_dmac_init_gbeth()
> 
>    ; not needed at the end of the comment. :-)
> 
> >
> > 2) Update the comment "PAUSE prohibition"-> "EMAC Mode: PAUSE
> >    prohibition; Duplex; TX; RX;" in ravb_emac_init_gbeth()
> >
> > 3) Document PFRI register bit, as it is only supported for
> >    R-Car Gen3 and RZ/G2L.
> 
>    Not a good idea to do 3 different things in 1 patch... I know I said
> that (2) isn't worth a separate patch but I meant that it shouldbe done as
> a part of a lrger ravb_emac_init_gbeth() change. Sorry for not being clear
> enough...

We are improving comments on Gbethernet driver, so I thought 1 patch will address
All the comments, since there is no functional change.

OK will create 3 separate patches for fixing these comments.

> 
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > ---
> > RFC changes:
> >  * New patch.
> > ---
> >  drivers/net/ethernet/renesas/ravb.h      | 2 +-
> >  drivers/net/ethernet/renesas/ravb_main.c | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> [...]
> > diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> > b/drivers/net/ethernet/renesas/ravb_main.c
> > index dfbbda3681f8..4a057005a470 100644
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -519,7 +519,7 @@ static void ravb_emac_init_gbeth(struct net_device
> *ndev)
> >  	/* Receive frame limit set register */
> >  	ravb_write(ndev, GBETH_RX_BUFF_MAX + ETH_FCS_LEN, RFLR);
> >
> > -	/* PAUSE prohibition */
> > +	/* EMAC Mode: PAUSE prohibition; Duplex; TX; RX; */
> 
>    No need for ; after RX.

OK.

Regards,
Biju