netdev - Re: [PATCH net-next 2/5] ethernet: tg3: remove direct netdev->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Oct 2021 11:57:30 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Siva Reddy Kallam <siva.kallam@...adcom.com>,
        Prashant Sreedharan <prashant@...adcom.com>,
        Michael Chan <mchan@...adcom.com>
Subject: Re: [PATCH net-next 2/5] ethernet: tg3: remove direct
 netdev->dev_addr writes

On Fri, Oct 8, 2021 at 10:59 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> tg3 does various forms of direct writes to netdev->dev_addr.
> Use a local buffer. Make sure local buffer is aligned since
> eth_platform_get_mac_address() may call ether_addr_copy().
>
> tg3_get_device_address() returns whenever it finds a method
> that found a valid address. Instead of modifying all the exit
> points pass the buffer from the outside and commit the address
> in the caller.
>
> Constify the argument of the set addr helper.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Thanks.
Reviewed-by: Michael Chan <michael.chan@...adcom.com>