netdev - Re: [PATCH net-next 2/7] gve: Add rx buffer pagecnt bias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211007193148.11d0b175@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 7 Oct 2021 19:31:48 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jeroen de Borst <jeroendb@...gle.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Catherine Sullivan <csully@...gle.com>,
        Yanchun Fu <yangchun@...gle.com>,
        Nathan Lewis <npl@...gle.com>,
        David Awogbemila <awogbemila@...gle.com>
Subject: Re: [PATCH net-next 2/7] gve: Add rx buffer pagecnt bias

On Thu,  7 Oct 2021 09:25:29 -0700 Jeroen de Borst wrote:
> From: Catherine Sullivan <csully@...gle.com>
> 
> Add a pagecnt bias field to rx buffer info struct to eliminate
> needing to increment the atomic page ref count on every pass in the
> rx hotpath.
> 
> Also prefetch two packet pages ahead.
> 
> Fixes: ede3fcf5ec67f ("gve: Add support for raw addressing to the rx path")
> Signed-off-by: Yanchun Fu <yangchun@...gle.com>
> Signed-off-by: Nathan Lewis <npl@...gle.com>
> Signed-off-by: Catherine Sullivan <csully@...gle.com>
> Signed-off-by: David Awogbemila <awogbemila@...gle.com>

drivers/net/ethernet/google/gve/gve_rx.c:521:5: warning: no previous prototype for ‘gve_clean_rx_done’ [-Wmissing-prototypes]
  521 | int gve_clean_rx_done(struct gve_rx_ring *rx, int budget,
      |     ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/google/gve/gve_rx.c:521:5: warning: symbol 'gve_clean_rx_done' was not declared. Should it be static?