netdev - RE: [PATCH] rtlwifi: rtl8192ee: Remove redundant initialization of variable version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e16b11a8d8f640d9be4ae2be21370d8a@realtek.com>
Date:   Fri, 8 Oct 2021 09:33:26 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     Colin King <colin.king@...onical.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] rtlwifi: rtl8192ee: Remove redundant initialization of variable version



> -----Original Message-----
> From: Colin King <colin.king@...onical.com>
> Sent: Friday, October 8, 2021 12:37 AM
> To: Pkshih <pkshih@...ltek.com>; Kalle Valo <kvalo@...eaurora.org>; David S . Miller
> <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; linux-wireless@...r.kernel.org;
> netdev@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] rtlwifi: rtl8192ee: Remove redundant initialization of variable version
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable version is being initialized with a value that is
> never read, it is being updated afterwards in both branches of
> an if statement. The assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> index 88fa2e593fef..76189283104c 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> @@ -1430,7 +1430,7 @@ static enum version_8192e _rtl92ee_read_chip_version(struct ieee80211_hw
> *hw)
>  {
>  	struct rtl_priv *rtlpriv = rtl_priv(hw);
>  	struct rtl_phy *rtlphy = &rtlpriv->phy;
> -	enum version_8192e version = VERSION_UNKNOWN;
> +	enum version_8192e version;
>  	u32 value32;
> 
>  	rtlphy->rf_type = RF_2T2R;
> --
> 2.32.0
> 
> ------Please consider the environment before printing this e-mail.


Acked-by: Ping-Ke Shih <pkshih@...ltek.com>