netdev - Re: [net-next PATCH v5 12/14] drivers: net: dsa: qca8k: add support for QCA8328

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e902fed0-cde8-ab81-c0d0-64bd296bbcba@gmail.com>
Date:   Sun, 10 Oct 2021 19:42:17 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Ansuel Smith <ansuelsmth@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH v5 12/14] drivers: net: dsa: qca8k: add support
 for QCA8328

Nit: please remove the "drivers: " prefix from your v6 and do that 
across your entire patch series.

On 10/10/2021 6:30 PM, Ansuel Smith wrote:
> QCA8328 switch is the bigger brother of the qca8327. Same regs different
> chip. Change the function to set the correct pin layout and introduce a
> new match_data to differentiate the 2 switch as they have the same ID
> and their internal PHY have the same ID.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian