netdev - RE: [EXT] [PATCH] qed: Fix missing error code in qed_slowpath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR18MB3900AFB7ECA41BC29B73B1B3A1B59@SJ0PR18MB3900.namprd18.prod.outlook.com>
Date:   Mon, 11 Oct 2021 05:17:32 +0000
From:   Alok Prasad <palok@...vell.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Ariel Elior <aelior@...vell.com>
CC:     GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: RE: [EXT] [PATCH] qed: Fix missing error code in qed_slowpath_start()

> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> Sent: 09 October 2021 13:39
> To: Ariel Elior <aelior@...vell.com>
> Cc: GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>; davem@...emloft.net;
> kuba@...nel.org; linux@...linux.org.uk; ast@...nel.org; daniel@...earbox.net;
> hawk@...nel.org; john.fastabend@...il.com; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; bpf@...r.kernel.org; chongjiapeng
> <jiapeng.chong@...ux.alibaba.com>
> Subject: [EXT] [PATCH] qed: Fix missing error code in qed_slowpath_start()
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: chongjiapeng <jiapeng.chong@...ux.alibaba.com>
> 
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'rc'.
> 
> Eliminate the follow smatch warning:
> 
> drivers/net/ethernet/qlogic/qed/qed_main.c:1298 qed_slowpath_start()
> warn: missing error code 'rc'.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Fixes: d51e4af5c209 ("qed: aRFS infrastructure support")
> Signed-off-by: chongjiapeng <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c
> b/drivers/net/ethernet/qlogic/qed/qed_main.c
> index 5e7242304ee2..359ad859ae18 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_main.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
> @@ -1295,6 +1295,7 @@ static int qed_slowpath_start(struct qed_dev *cdev,
>  			} else {
>  				DP_NOTICE(cdev,
>  					  "Failed to acquire PTT for aRFS\n");
> +				rc = -EINVAL;
>  				goto err;
>  			}
>  		}
> --
> 2.19.1.6.gb485710b

Thanks!

Acked-by: Alok Prasad <palok@...vell.com>