netdev - Re: [PATCH v2 net 09/10] net: dsa: tag_ocelot_8021q: fix inability to inject STP BPDUs into BLOCKING ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83d7644b-78e0-9b18-41e8-62a730c1a0f6@gmail.com>
Date:   Tue, 12 Oct 2021 14:42:42 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, Po Liu <po.liu@....com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Michael Walle <michael@...le.cc>,
        Rui Sousa <rui.sousa@....com>, Yangbo Lu <yangbo.lu@....com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v2 net 09/10] net: dsa: tag_ocelot_8021q: fix inability to
 inject STP BPDUs into BLOCKING ports

On 10/12/21 4:40 AM, Vladimir Oltean wrote:
> When setting up a bridge with stp_state 1, topology changes are not
> detected and loops are not blocked. This is because the standard way of
> transmitting a packet, based on VLAN IDs redirected by VCAP IS2 to the
> right egress port, does not override the port STP state (in the case of
> Ocelot switches, that's really the PGID_SRC masks).
> 
> To force a packet to be injected into a port that's BLOCKING, we must
> send it as a control packet, which means in the case of this tagger to
> send it using the manual register injection method. We already do this
> for PTP frames, extend the logic to apply to any link-local MAC DA.
> 
> Fixes: 7c83a7c539ab ("net: dsa: add a second tagger for Ocelot switches based on tag_8021q")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian