netdev - Re: [PATCH] nfp: flow_offload: move flow_indr_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211011171512.71ed15ae@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 11 Oct 2021 17:15:12 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     louis.peens@...igine.com
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        oss-drivers@...igine.com, simon.horman@...igine.com,
        Baowen Zheng <baowen.zheng@...igine.com>
Subject: Re: [PATCH] nfp: flow_offload: move flow_indr_dev_register from app
 init to app start

On Mon, 11 Oct 2021 17:32:00 +0200 louis.peens@...igine.com wrote:
> @@ -942,6 +938,10 @@ static int nfp_flower_start(struct nfp_app *app)
>  			return err;
>  	}
>  
> +	err = flow_indr_dev_register(nfp_flower_indr_setup_tc_cb, app);
> +	if (err)
> +		return err;
> +
>  	return nfp_tunnel_config_start(app);

You need to add an error path if nfp_tunnel_config_start() fails, now.