| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <cf511a7f-531f-4555-d7b4-cb171a615fdd@redhat.com>
Date: Wed, 13 Oct 2021 18:00:01 +0200
From: David Hildenbrand <david@...hat.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: linux-kernel@...r.kernel.org, Jeff Dike <jdike@...toit.com>,
Richard Weinberger <richard@....at>,
Anton Ivanov <anton.ivanov@...bridgegreys.com>,
Jason Wang <jasowang@...hat.com>,
Paolo Bonzini <pbonzini@...hat.com>,
Stefan Hajnoczi <stefanha@...hat.com>,
Jens Axboe <axboe@...nel.dk>,
Marcel Holtmann <marcel@...tmann.org>,
Johan Hedberg <johan.hedberg@...il.com>,
Luiz Augusto von Dentz <luiz.dentz@...il.com>,
Matt Mackall <mpm@...enic.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
Amit Shah <amit@...nel.org>, Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Gonglei <arei.gonglei@...wei.com>,
"David S. Miller" <davem@...emloft.net>,
Sudeep Holla <sudeep.holla@....com>,
Cristian Marussi <cristian.marussi@....com>,
"Enrico Weigelt, metux IT consult" <info@...ux.net>,
Viresh Kumar <vireshk@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
David Airlie <airlied@...ux.ie>,
Gerd Hoffmann <kraxel@...hat.com>,
Daniel Vetter <daniel@...ll.ch>, Jie Deng <jie.deng@...el.com>,
Jean-Philippe Brucker <jean-philippe@...aro.org>,
Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
Jakub Kicinski <kuba@...nel.org>,
Johannes Berg <johannes@...solutions.net>,
Kalle Valo <kvalo@...eaurora.org>,
Dan Williams <dan.j.williams@...el.com>,
Vishal Verma <vishal.l.verma@...el.com>,
Dave Jiang <dave.jiang@...el.com>,
Ira Weiny <ira.weiny@...el.com>,
Ohad Ben-Cohen <ohad@...ery.com>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Vivek Goyal <vgoyal@...hat.com>,
Miklos Szeredi <miklos@...redi.hu>,
Eric Van Hensbergen <ericvh@...il.com>,
Latchesar Ionkov <lucho@...kov.net>,
Dominique Martinet <asmadeus@...ewreck.org>,
Stefano Garzarella <sgarzare@...hat.com>,
Anton Yakovlev <anton.yakovlev@...nsynergy.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, linux-um@...ts.infradead.org,
virtualization@...ts.linux-foundation.org,
linux-block@...r.kernel.org, linux-bluetooth@...r.kernel.org,
linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-gpio@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-i2c@...r.kernel.org, iommu@...ts.linux-foundation.org,
netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
nvdimm@...ts.linux.dev, linux-remoteproc@...r.kernel.org,
linux-scsi@...r.kernel.org, linux-fsdevel@...r.kernel.org,
v9fs-developer@...ts.sourceforge.net, kvm@...r.kernel.org,
alsa-devel@...a-project.org
Subject: Re: [PATCH RFC] virtio: wrap config->reset calls
On 13.10.21 14:17, Michael S. Tsirkin wrote:
> On Wed, Oct 13, 2021 at 01:03:46PM +0200, David Hildenbrand wrote:
>> On 13.10.21 12:55, Michael S. Tsirkin wrote:
>>> This will enable cleanups down the road.
>>> The idea is to disable cbs, then add "flush_queued_cbs" callback
>>> as a parameter, this way drivers can flush any work
>>> queued after callbacks have been disabled.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
>>> ---
>>> arch/um/drivers/virt-pci.c | 2 +-
>>> drivers/block/virtio_blk.c | 4 ++--
>>> drivers/bluetooth/virtio_bt.c | 2 +-
>>> drivers/char/hw_random/virtio-rng.c | 2 +-
>>> drivers/char/virtio_console.c | 4 ++--
>>> drivers/crypto/virtio/virtio_crypto_core.c | 8 ++++----
>>> drivers/firmware/arm_scmi/virtio.c | 2 +-
>>> drivers/gpio/gpio-virtio.c | 2 +-
>>> drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +-
>>> drivers/i2c/busses/i2c-virtio.c | 2 +-
>>> drivers/iommu/virtio-iommu.c | 2 +-
>>> drivers/net/caif/caif_virtio.c | 2 +-
>>> drivers/net/virtio_net.c | 4 ++--
>>> drivers/net/wireless/mac80211_hwsim.c | 2 +-
>>> drivers/nvdimm/virtio_pmem.c | 2 +-
>>> drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
>>> drivers/scsi/virtio_scsi.c | 2 +-
>>> drivers/virtio/virtio.c | 5 +++++
>>> drivers/virtio/virtio_balloon.c | 2 +-
>>> drivers/virtio/virtio_input.c | 2 +-
>>> drivers/virtio/virtio_mem.c | 2 +-
>>> fs/fuse/virtio_fs.c | 4 ++--
>>> include/linux/virtio.h | 1 +
>>> net/9p/trans_virtio.c | 2 +-
>>> net/vmw_vsock/virtio_transport.c | 4 ++--
>>> sound/virtio/virtio_card.c | 4 ++--
>>> 26 files changed, 39 insertions(+), 33 deletions(-)
>>>
>>> diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
>>> index c08066633023..22c4d87c9c15 100644
>>> --- a/arch/um/drivers/virt-pci.c
>>> +++ b/arch/um/drivers/virt-pci.c
>>> @@ -616,7 +616,7 @@ static void um_pci_virtio_remove(struct virtio_device *vdev)
>>> int i;
>>> /* Stop all virtqueues */
>>> - vdev->config->reset(vdev);
>>> + virtio_reset_device(vdev);
>>> vdev->config->del_vqs(vdev);
>>
>> Nit: virtio_device_reset()?
>>
>> Because I see:
>>
>> int virtio_device_freeze(struct virtio_device *dev);
>> int virtio_device_restore(struct virtio_device *dev);
>> void virtio_device_ready(struct virtio_device *dev)
>>
>> But well, there is:
>> void virtio_break_device(struct virtio_device *dev);
>
> Exactly. I don't know what's best, so I opted for plain english :)
Fair enough, LGTM
Reviewed-by: David Hildenbrand <david@...hat.com>
--
Thanks,
David / dhildenb
Powered by blists - more mailing lists