netdev - Re: [PATCH net-next v3 13/14] ravb: Update ravb_emac_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <52132e66-79e4-8e0e-82bc-5aa16f00175f@omp.ru>
Date:   Wed, 13 Oct 2021 19:03:15 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Biju Das <biju.das.jz@...renesas.com>,
        Sergei Shtylyov <sergei.shtylyov@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Geert Uytterhoeven" <geert+renesas@...der.be>,
        Sergey Shtylyov <s.shtylyov@...russia.ru>,
        Adam Ford <aford173@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Yuusuke Ashizuka <ashiduka@...itsu.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org\"" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        "Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH net-next v3 13/14] ravb: Update ravb_emac_init_gbeth()

On 10/13/21 6:57 PM, Jakub Kicinski wrote:

>>    Ah, I think it's the (usual) checksum-vs-CRC mixup. I don't know
>> why TOE needs CRC tho but it's 4 bytes at the end of a frame, not
>> having much toi do with the 2-byte checksums...

   s/toi/to/.

> Meaning v3 is good as is? I'm trying understand if I should apply it ;)

   Yes, I'm giving up (-:

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

MBR, Sergey