netdev - Re: [PATCH] include: marvell: octeontx2: build error: unknown type name 'u64'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211013132704.75fa98ec@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 13 Oct 2021 13:27:04 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     bbrezillon@...nel.org, arno@...isbad.org, schalla@...vell.com,
        sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
        hkelam@...vell.com, linux-crypto@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] include: marvell: octeontx2: build error: unknown type
 name 'u64'

On Wed, 13 Oct 2021 08:40:20 -0700 Jakub Kicinski wrote:
> On Wed, 13 Oct 2021 15:57:43 +0200 Anders Roxell wrote:
> > Building an allmodconfig kernel arm64 kernel, the following build error
> > shows up:
> > 
> > In file included from drivers/crypto/marvell/octeontx2/cn10k_cpt.c:4:
> > include/linux/soc/marvell/octeontx2/asm.h:38:15: error: unknown type name 'u64'
> >    38 | static inline u64 otx2_atomic64_fetch_add(u64 incr, u64 *ptr)
> >       |               ^~~
> > 
> > Include linux/types.h in asm.h so the compiler knows what the type
> > 'u64' are.
> > 
> > Fixes: af3826db74d1 ("octeontx2-pf: Use hardware register for CQE count")
> > Signed-off-by: Anders Roxell <anders.roxell@...aro.org>  
> 
> Yes, please! I've been carrying same patch locally. Any expectations on
> who should apply the patch? I'm gonna send a PR with networking fixes
> to Linus tomorrow, happy to take it via netdev if that's okay.

I realized the breakage only exists in net-next so applied 
the fix there. Thanks!