netdev - Re: [PATCH] net: encx24j600: check error in devm_regmap_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211013162211.6cacd0e5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 13 Oct 2021 16:22:11 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Nanyong Sun <sunnanyong@...wei.com>
Cc:     <davem@...emloft.net>, <yashsri421@...il.com>,
        <weiyongjun1@...wei.com>, <krzysztof.kozlowski@...onical.com>,
        <shenyang39@...wei.com>, <dingsenjie@...ong.com>,
        <rdunlap@...radead.org>, <jringle@...dpoint.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: encx24j600: check error in
 devm_regmap_init_encx24j600

On Tue, 12 Oct 2021 20:59:01 +0800 Nanyong Sun wrote:
> devm_regmap_init may return error which caused by like out of memory,
> this will results in null pointer dereference later when reading
> or writing register:

Applied, but...


> -void devm_regmap_init_encx24j600(struct device *dev,
> +int devm_regmap_init_encx24j600(struct device *dev,
>  				 struct encx24j600_context *ctx)

> -void devm_regmap_init_encx24j600(struct device *dev,
> +int devm_regmap_init_encx24j600(struct device *dev,
>  				 struct encx24j600_context *ctx);

.. please make sure you adjust the continuation lines.
checkpatch points this out.