netdev - Re: [PATCH net-next 3/7] ethernet: make use of eth_hw_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbVqFkNNbJ9RUTJioG3F8Hx=ryvM-uVHV0x5KV8yYUHWQ@mail.gmail.com>
Date:   Thu, 14 Oct 2021 01:50:15 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, chris.snook@...il.com,
        Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Salil Mehta <salil.mehta@...wei.com>, subashab@...eaurora.org,
        stranche@...eaurora.org, Michael Walle <michael@...le.cc>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next 3/7] ethernet: make use of eth_hw_addr_random()
 where appropriate

On Wed, Oct 13, 2021 at 10:44 PM Jakub Kicinski <kuba@...nel.org> wrote:

> Number of drivers use eth_random_addr(netdev->dev_addr)
> thus writing to netdev->dev_addr directly, and not setting
> the address type. Switch them to eth_hw_addr_random().
>
>   @@
>   expression netdev;
>   @@
>   - eth_random_addr(netdev->dev_addr);
>   + eth_hw_addr_random(netdev);
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Oh this is better.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij