netdev - Re: [PATCH net-next 3/3] net, neigh: Reject creating NUD_PERMANENT with NTF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4553162b-86df-38f5-cd26-107bdee40116@gmail.com>
Date:   Wed, 13 Oct 2021 21:11:14 -0600
From:   David Ahern <dsahern@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>, davem@...emloft.net,
        kuba@...nel.org
Cc:     roopa@...dia.com, dsahern@...nel.org, m@...bda.lt,
        john.fastabend@...il.com, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] net, neigh: Reject creating NUD_PERMANENT
 with NTF_MANAGED entries

On 10/13/21 7:21 AM, Daniel Borkmann wrote:
> The combination of NUD_PERMANENT + NTF_MANAGED is not supported and does
> not make sense either given the former indicates a static/fixed neighbor
> entry whereas the latter a dynamically resolved one. While it is possible
> to transition from one over to the other, we should however reject such
> creation attempts.
> 
> Fixes: 7482e3841d52 ("net, neigh: Add NTF_MANAGED flag for managed neighbor entries")
> Suggested-by: David Ahern <dsahern@...nel.org>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> ---
>  net/core/neighbour.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>