netdev - Re: [PATCH iproute2 v5 7/7] configure: add the --libdir option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211014111725.GK1668@orbyte.nwl.cc>
Date:   Thu, 14 Oct 2021 13:17:25 +0200
From:   Phil Sutter <phil@....cc>
To:     Andrea Claudi <aclaudi@...hat.com>
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org,
        dsahern@...il.com, bluca@...ian.org, haliu@...hat.com
Subject: Re: [PATCH iproute2 v5 7/7] configure: add the --libdir option

On Thu, Oct 14, 2021 at 01:02:41PM +0200, Andrea Claudi wrote:
> On Thu, Oct 14, 2021 at 12:10:53PM +0200, Phil Sutter wrote:
> > Hi Andrea,
> > 
> > On Thu, Oct 14, 2021 at 10:50:55AM +0200, Andrea Claudi wrote:
> > [...]
> > > diff --git a/Makefile b/Makefile
> > > index 5eddd504..f6214534 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -1,6 +1,8 @@
> > >  # SPDX-License-Identifier: GPL-2.0
> > >  # Top level Makefile for iproute2
> > >  
> > > +-include config.mk
> > > +
> > 
> > Assuming config.mk may be missing (as dash-prefix is used).
> > 
> > >  ifeq ("$(origin V)", "command line")
> > >  VERBOSE = $(V)
> > >  endif
> > > @@ -13,7 +15,6 @@ MAKEFLAGS += --no-print-directory
> > >  endif
> > >  
> > >  PREFIX?=/usr
> > > -LIBDIR?=$(PREFIX)/lib
> > 
> > Dropping this leads to trouble if config.mk is missing or didn't define
> > it. Can't you just leave it in place? Usually config.mk would override
> > it anyway, no?
> 
> config.mk may miss at the first make call, but the "all" target calls
> config.mk, which in turns re-generate it. Thus LIBDIR is defined when
> the target all executes.

Ah, I forgot the call to configure from make. So full series:

Acked-by: Phil Sutter <phil@....cc>

Thanks, Phil